build: pin toolchain and neutralize stale host GOROOT#23
Open
syscod3 wants to merge 1 commit into
Open
Conversation
syscod3
force-pushed
the
build/toolchain-goroot-fix
branch
from
af196c0 to
b8e3536
Compare
… GOROOT Move to a reproducible, host-independent Go toolchain via go.mod's `toolchain go1.26.4` directive: with GOTOOLCHAIN=auto, every go command fetches (checksum-verified via the module mirror) and runs exactly go1.26.4 regardless of the host's installed Go. Aligns go.mod, .mise.toml, and CI GO_VERSION on 1.26, which also lets setup-envtest@latest install (it now requires go >= 1.26), fixing the CI unit-test job. Makefile unexports GOROOT and .mise.toml unsets it so a stale host GOROOT (pointing at a different Go install/patch) cannot cause 'compile: version mismatch' — still needed on 1.26 since the host GOROOT patch may differ from the pinned toolchain.
syscod3
force-pushed
the
build/toolchain-goroot-fix
branch
from
b8e3536 to
1f84e15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 'compile: version go1.X.0 does not match go tool version go1.Y.Z' build failures caused by a stale
GOROOTexported by the host shell (pointing at a different Go than the mise-managed toolchain on PATH).Changes
unexport GOROOT— every recipe uses the go binary's own GOROOT, independent of the host's Go install.[env] GOROOT = false— under mise activation, the pinnedgo = "1.25.8"toolchain is used regardless of any host GOROOT.Verification
make buildandGOOS=linux mise exec -- go build ./...both pass with a staleGOROOT=/usr/local/Cellar/go/1.26.0/libexecstill exported.Independent of any feature work; landing on main so all agents/devs get a reproducible build.